Conversation
|
PR Packages Published Python Package:
NPM Package:
|
|
The latest Buf updates on your PR. Results from workflow Pull Request / linting (pull_request).
|
baranbartu
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces additive, non-breaking API fields to support the Hybrid Cloud Environment creation redesign (3-step flow with explicit storage configuration), while preserving existing behavior for external API consumers.
It adds a new enum to represent the readiness state of storage configuration in a hybrid cloud environment and integrates it into the
HybridCloudEnvironmentStatusstruct. At the same time it introduces a newenumfor providing a reason why a cluster can't be created (or shouldn't) for aCloudProviderRegion, this will help slowly rolling out the transition before we switch available to false. See the detailed explanation below.The goal is to enable finer-grained cluster creation gating in Cloud UI without changing the current meaning of existing fields (especially available).
Background
We are moving from an implicit/default storage behavior to an explicit storage configuration requirement in the Cloud UI flow.
At the same time, we are backfilling existing in-use environments that currently rely on defaults.
We need to expose enough status detail so UI can safely block/allow cluster creation, but without introducing breaking changes for current Public API consumers.
Why This Approach
Boolean fields are difficult to evolve in public contracts (true/false/null quickly becomes insufficient).
Enums provide forward-compatible extensibility for new states (e.g. backfill in progress, invalid configuration, policy restrictions).
API Changes (Additive)
HybridCloudEnvironmentStatus.storage_configuration_readiness (enum)
CloudProviderRegion.cluster_creation_blocking_reason (enum)
Compatibility and Breaking-Change Considerations
Rollout Plan
Risk Assessment
Low risk to existing integrations (additive API changes only).
Main risk is semantic confusion between availableand creation gating; mitigated via explicit cluster_creation_blocking_reason and docs.